Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of expressions in repl #80

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

arnodel
Copy link
Owner

@arnodel arnodel commented Jan 26, 2022

The minimal repl had a hack to deal with expressions such as '1+1'
This implements a tool in runtime package to handle those more
gracefully

The minimal repl had a hack to deal with expressions such as '1+1'
This implements a tool in runtime package to handle those more
gracefully
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #80 (e680ec6) into lua5.4 (866962c) will increase coverage by 0.08%.
The diff coverage is 85.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           lua5.4      #80      +/-   ##
==========================================
+ Coverage   88.50%   88.58%   +0.08%     
==========================================
  Files          95       95              
  Lines       10435    10500      +65     
==========================================
+ Hits         9235     9301      +66     
+ Misses        921      920       -1     
  Partials      279      279              
Impacted Files Coverage Δ
lib/golib/govalue.go 94.50% <76.92%> (+2.38%) ⬆️
runtime/lib.go 79.01% <86.79%> (+1.10%) ⬆️
runtime/syntaxerror.go 100.00% <100.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866962c...e680ec6. Read the comment docs.

@arnodel arnodel merged commit 478648e into lua5.4 Feb 1, 2022
@arnodel arnodel deleted the improve-repl-expression-handling branch February 1, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants