Skip to content
This repository has been archived by the owner on Jan 28, 2023. It is now read-only.

Gmail image proxy not being detected correctly #142

Open
HaraldWalker opened this issue Jan 21, 2019 · 2 comments
Open

Gmail image proxy not being detected correctly #142

HaraldWalker opened this issue Jan 21, 2019 · 2 comments

Comments

@HaraldWalker
Copy link
Contributor

The user agent string of the Google image proxy (used by Gmail) is not being parsed correctly.

How to test:
Parse user agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko Firefox/11.0 (via ggpht.com GoogleImageProxy)

UAS version 20141024-01 result:
Family: gmail image proxy
Type: other
OS: Linux
Device category: other

UAS version 20190121-02 (old xml format) result:
Family: unknown
Type: email client
OS: Linux
Device category: personal computer

Udger online parser result:
Family: Gmail
Type: email client
OS: unknown
Device category: desktop

Cause:
In the UAS XML the browser type 499 changed both name and type.
name: 'Gmail image proxy' changed to 'Gmail'
type: '20' changed to '4'

Expected result:
Familiy: both Gmail image proxy or Gmail are fine. Since we use enums, we can't simply rename it without breaking implementations. I prefer 'Gmail image proxy' as it behaves like other proxies and knowing that is important for understanding the statistics.
Type: email client (I would prefer webmail client as type but that doesn't exist)
OS: unknown. Partly an UAS XML issue. The browser 499 is mapped to Linux as OS. In the 2019 version of the UAS XML, there is a 2nd matcher on the user agent string for operating system and here it maps it to 'unknown'. But uadetector seems to use the OS from the browser family.
Device: unknown. The gmail app on mobile uses the same user agent string. Also visiting the gmail site on mobile or tablet would use the same user agent string. So, we simply do not know what OS or device type was used. Might be an UAS issue since Udger online parser also returns desktop.

This issue also raises the question of how many other changes like this do we have in the latest version of the UAS database and how can uadetector stay compatible with different versions, including running the unit tests on the old 2014 database.

@HaraldWalker
Copy link
Contributor Author

HaraldWalker commented Jan 21, 2019

I'll have a fix for family.
OS and device category are UAS data issues. Some browsers have an OS defined and in that case uadetector uses that value instead of detecting the operating system by OS regex. From a performance point of view that is the correct behavior. UAS database should remove the mapping of browser 499 to Linux. I've reported this to Udger.

Tried to find other issues with new UAS version but it is almost impossible to run the 2014 unit tests with the 2019/01 version. Too many things changed (like company and product names, product urls etc.).
Checked several issues that had been reported here and those all got parsed correctly.

@HaraldWalker
Copy link
Contributor Author

The mapping between browser 499 (gmail) and OS id 19 (Linux) has been removed from UAS database version 20190122-01. uadetector now reports 'Unknown' as OS.

HaraldWalker pushed a commit to HaraldWalker/uadetector that referenced this issue Jan 22, 2019
HaraldWalker pushed a commit to HaraldWalker/uadetector that referenced this issue Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant