Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dupeGuru 4.0.3 - installer languages (Windows) #461

Closed
smaragdus opened this issue Nov 15, 2017 · 1 comment
Closed

dupeGuru 4.0.3 - installer languages (Windows) #461

smaragdus opened this issue Nov 15, 2017 · 1 comment
Assignees
@arsenetar
Labels
bug Bug reports. Windows Related to running on Windows.

Comments

@smaragdus
Copy link

The installer of dupeGuru version 4.0.3 (dupeguru_win64_4.0.3.exe) allows only two languages to choose from- Russian and Ukrainian:

dupeguru 4 0 3 - 2017-11-15 - 002

However after installation the program runs in English.

I suppose that the installer tries to use the system language and this erroneous behaviour comes from there. I happen to understand some Russian so I was able to go through the installation but such absurd behaviour (the installer tries to be smart but is actually dull) would discourage other users.

A possible workaround is the extraction of the installer.

Expected behaviour of the installer- it offers all (16) supported languages to choose from, not only Russian and Ukrainian.
@smaragdus smaragdus changed the title dupeGuru 4.0.3 - installer languages dupeGuru 4.0.3 - installer languages (Windows) Nov 15, 2017
@ghost ghost assigned arsenetar Nov 15, 2017
@ghost ghost added the Windows Related to running on Windows. label Nov 15, 2017
@arsenetar arsenetar added the bug Bug reports. label Nov 16, 2017
@arsenetar
Copy link
Owner

I have updated the installer script which should force it to show all the languages in the selection dialog. It seems the selection reduction is may not be desired. The installer only supports 13 of the 16 languages right now.

@arsenetar arsenetar added this to the 4.0.4 milestone Feb 17, 2018
@arsenetar arsenetar mentioned this issue Feb 25, 2018
Merged
ghost pushed a commit that referenced this issue Feb 26, 2018
@arsenetar
Fix #456 & #461 (#491)
f349f6a 
* Update setup.nsi
- Always display all language choices to fix #461
- Stop recursively removing installation directory as that
  is not a safe operation.  This may leave the installation
  directory after uninstallation but should be empty.  Fix #456.

* Update requirements-windows.txt
- Add pypiwin32 for cx-freeze as it was issuing a warning
- Prevent version 5.1.0 of cx-freeze as it produces non-working
  packages for some reason.  Version 5.0.2 and 6.0b1 work fine.

* Update setup to delete correct files

Installer will now delete the files in the installation folder along
with the folder if it is empty.  Bumped minimum cx-Freeze version to
5.1.1 as files are structured differently in older versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arsenetar arsenetar

Labels
bug Bug reports. Windows Related to running on Windows.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arsenetar @smaragdus