Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original file line color scheme is unreadable #894

Closed
AlttiRi opened this issue May 20, 2021 · 9 comments
Closed

Original file line color scheme is unreadable #894

AlttiRi opened this issue May 20, 2021 · 9 comments
Labels
enhancement Feature requests and enhancements.

Comments

@AlttiRi
Copy link
Contributor

AlttiRi commented May 20, 2021

I think that the lines with the original files have questionable color scheme. While it uses very bright #0000FF color, the line is not contrast on #808080 background, it's hard to read.
To look at this text is always the pain for my eyes. Since that update when it was changed.

image


Even Lightroom agrees with me:

image

The approximate CSS:

    font-family: sans-serif;
    font-size: 11px;
    color: blue;
    font-weight: bold;
    background: gray;
@AlttiRi AlttiRi added the enhancement Feature requests and enhancements. label May 20, 2021
@glubsy
Copy link
Contributor

glubsy commented May 20, 2021

Which version are you talking about? You can change the colours in the preferences.

@AlttiRi
Copy link
Contributor Author

AlttiRi commented May 20, 2021

4.1.1

Oh. I did not note the existence of the preferences, thanks. Yeah, I can change it.

But may be use something better for the default preset for this?
For example, I just changed #808080 to #c2c2c2 and now it looks much better.

@glubsy
Copy link
Contributor

glubsy commented May 20, 2021

I suspect themes might apply their own styles anyway, so it is difficult to have a "default" preset.

@AlttiRi
Copy link
Contributor Author

AlttiRi commented May 21, 2021

In Linux the same colors are:
Screenshot
It looks a bit better only thanks to the bigger text.

It highly seems that the default colors are hardcoded. So, it's the default preset.

Neither Windows, or any known for me Linux dist do not use blue text on grey background in any component.

@AlttiRi
Copy link
Contributor Author

AlttiRi commented May 21, 2021

Here is it.

dupeguru/qt/preferences.py

Lines 104 to 105 in 4a40b34

self.result_table_ref_foreground_color = QColor(Qt.blue)
self.result_table_ref_background_color = QColor(Qt.darkGray)

It's the default preset.

@AlttiRi
Copy link
Contributor Author

AlttiRi commented May 21, 2021

I think it would be better to change Qt.darkGray (#808080) to Qt.lightGray (#c0c0c0).

@AlttiRi
Copy link
Contributor Author

AlttiRi commented May 21, 2021

To look at this text is always the pain for my eyes. Since that update when it was changed.

How it looked earlier:

screen-from-internet

@glubsy
Copy link
Contributor

glubsy commented May 21, 2021

I agree a lighter gray would be better by default. Since you have identified the changes needed, why not submit a merge request?

arsenetar added a commit that referenced this issue May 26, 2021
Change reference background color #894
@arsenetar
Copy link
Owner

Closing since #898 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and enhancements.
Projects
None yet
Development

No branches or pull requests

3 participants