Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect stdout from custom command to the log files #1008

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Redirect stdout from custom command to the log files #1008

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
605c8cc
Attempt to use pipe to store log
MYanello Jun 12, 2022
22b2b6b
"Send the logs for the custom command subprocess to the logs"
MYanello Jun 12, 2022
d219519
Remove line break from custom command log
MYanello Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,13 @@ def invoke_custom_command(self):
# a workaround to make the damn thing work.
exepath, args = match.groups()
path, exename = op.split(exepath)
subprocess.Popen(exename + args, shell=True, cwd=path)
p = subprocess.Popen(exename + args, shell=True, cwd=path, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
output = p.stdout.read()
logging.info("Custom command %s %s:\n %s", exename, args, output)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other log entries are single line, I would prefer to keep these entries single line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks

else:
subprocess.Popen(dupe_cmd, shell=True)
p = subprocess.Popen(dupe_cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
output = p.stdout.read()
logging.info("Custom command %s:\n %s", dupe_cmd, output)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other log entries are single line, I would prefer to keep these entries single line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks


def load(self):
"""Load directory selection and ignore list from files in appdata.
Expand Down