Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile compatibility with macOS #575

Closed
wants to merge 1 commit into from
Closed

Conversation

lhaeger
Copy link

@lhaeger lhaeger commented Jun 26, 2019

macOS ships BSD uname, which has no option "-o", so make fails. Change this to use bash ${OSTYPE} instead, which is platform independent.

macOS ships BSD uname, which has no option "-o", so make fails. Change this to use bash ${OSTYPE} instead, which is platform independent.
@lhaeger lhaeger changed the title Makefile comaptibility with macOS Makefile compatibility with macOS Jun 26, 2019
@jpvlsmv
Copy link
Contributor

jpvlsmv commented Jul 27, 2019

In fact, I ran into a similar problem when not using the msys-compiled Windows systems... they don't have a uname command at all.

How about python -e 'import sys;print(sys.platform)' ?

@arsenetar
Copy link
Owner

@lhaeger, I think I like the suggestion from @jpvlsmv as it only depends on python to be installed (which we need anyhow), there may be systems without bash. I think that would be more platform independent in the long run unless I am missing something.

@lhaeger
Copy link
Author

lhaeger commented Aug 30, 2019

Whatever works is fine with me. I‘ll close this PR and leave that up to you.

@lhaeger lhaeger closed this Aug 30, 2019
arsenetar added a commit that referenced this pull request Sep 10, 2019
@arsenetar
Copy link
Owner

Went ahead with ${PYTHON} -c "import platform; print(platform.system())" as it seemed to give a nice "Windows", "Linux" output where sys.platform gave win32 win64 etc. It seemed like the platform.system() gave easier to handle output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants