Change abandon timeout, fix issue #76

README.md

@@ -267,6 +267,10 @@ to build a tool for their own needs from that.
 
 ## Change log
 
+### 1.9.3 (unreleased)
+
+- Reduce timeout for changing "Pending" recurring contributions to "Failed" from 24 hours to 0.66 hours. See https://github.com/artfulrobot/uk.artfulrobot.civicrm.gocardless/issues/76 You can still override this as a parameter, should you wish.
+
 ### 1.9.2
 
 - Move to `Payment.create` API instead of older (and deprecated) `Contribution.completetransaction` API.

api/v3/Job/Gocardlessfailabandoned.mgd.php

@@ -12,7 +12,7 @@
     array(
       'version' => 3,
       'name' => 'GoCardless: mark abandoned Pending recurring contributions Failed',
-      'description' => 'If a user starts to donate but abandons on the GoCardless page their ContributionRecur record gets stuck at Pending/Incomplete. This job marks those as Failed after 24 hours so you can see abandoned payments.',
+      'description' => 'If a user starts to donate but abandons on the GoCardless page their ContributionRecur record gets stuck at Pending/Incomplete. This job marks those as Failed after 40 mins (GoCardless only allows 30 mins to complete a redirect flow) so you can see abandoned recurring contributions. You may choose to lengthen the interval to 1.5 hours if you want to allow for someone setting up a mandate at the cusp of a daylight saving hour change.',
       'run_frequency' => 'Always',
       'api_entity' => 'Job',
       'api_action' => 'Gocardlessfailabandoned',

api/v3/Job/Gocardlessfailabandoned.php

@@ -10,8 +10,8 @@
  */
 function _civicrm_api3_job_Gocardlessfailabandoned_spec(&$spec) {
   $spec['timeout']['description'] = 'How long (hours) before we consider '
-    . 'Pending ContributionRecur records as abandoned. Default: 24';
-  $spec['timeout']['api.default'] = 24;
+    . 'Pending ContributionRecur records as abandoned. Default: 0.66 (c40 mins)';
+  $spec['timeout']['api.default'] = 0.66;
 }
 
 /**

info.xml

@@ -17,7 +17,7 @@
     <url desc="Licensing">http://www.gnu.org/licenses/agpl-3.0.html</url>
   </urls>
   <releaseDate>2020-03-24</releaseDate>
-  <version>1.9.2</version>
+  <version>1.9.3</version>
   <develStage>stable</develStage>
   <compatibility>
     <ver>4.7</ver>