Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Correct payment_instrument_id and payment_type values in processor definitions. #67

Closed
artfulrobot opened this issue Jan 31, 2020 · 1 comment
Milestone

Comments

@artfulrobot
Copy link
Owner

It seems that both the Payment Processor Type and the Payment Processor records were not set correctly historically:

  • payment_type is defined as 1 = credit card, 2 = direct debit. So we should be using 2.
  • payment_instrument_id seems to have defaulted to 1 (i.e. credit card unless you have a non-standard install), but should point to the instrument created for GoCardless.

I don't think this will have affected anything but it should be corrected.

artfulrobot pushed a commit that referenced this issue Jan 31, 2020
@artfulrobot artfulrobot added this to the 1.10 milestone Jan 31, 2020
@artfulrobot artfulrobot modified the milestones: 1.10, 1.9.2 Feb 6, 2020
@artfulrobot
Copy link
Owner Author

Closing as fixed in 1.9.2beta2, will make 1.9.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant