fix: aborted requests do not clear its cache afterwards if previous r…

…equest was cached (#922)

src/interceptors/response.ts

@@ -15,9 +15,15 @@ export function defaultResponseInterceptor(axios: AxiosCacheInstance): ResponseI
    *
    * Also update the waiting list for this key by rejecting it.
    */
-  const rejectResponse = async (responseId: string, config: CacheRequestConfig) => {
+  const rejectResponse = async (
+    responseId: string,
+    config: CacheRequestConfig,
+    clearCache = true
+  ) => {
     // Updates the cache to empty to prevent infinite loading state
-    await axios.storage.remove(responseId, config);
+    if (clearCache) {
+      await axios.storage.remove(responseId, config);
+    }
 
     // Rejects the deferred, if present
     const deferred = axios.waiting.get(responseId);
@@ -297,7 +303,11 @@ export function defaultResponseInterceptor(axios: AxiosCacheInstance): ResponseI
       }
 
       // Rejects all other requests waiting for this response
-      await rejectResponse(id, config);
+      await rejectResponse(
+        id,
+        config,
+        error.code !== 'ERR_CANCELED' || (error.code === 'ERR_CANCELED' && cache.state !== 'cached')
+      );
 
       throw error;
     }

test/interceptors/response.test.ts

@@ -361,4 +361,33 @@ describe('Response Interceptor', () => {
     assert.equal(storage.state, 'cached');
     assert.equal(storage.data?.data, true);
   });
+
+  // https://github.com/arthurfiorette/axios-cache-interceptor/issues/922
+  it('Aborted requests do not clear its cache afterwards if previous request was cached', async () => {
+    const axios = mockAxios();
+
+    const id = '1';
+
+    // first request
+    await axios.get('url', { id });
+
+    // Second request cancelled
+    const controller = new AbortController();
+    const cancelled = axios.get('url', { id, signal: controller.signal });
+    controller.abort();
+    try {
+      await cancelled;
+      assert.fail('should have thrown an error');
+    } catch (error: any) {
+      assert.equal(error.code, 'ERR_CANCELED');
+    }
+
+    // Third request
+    const promise = axios.get('url', { id });
+
+    const response = await promise;
+
+    // Third request should still have cached data
+    await assert.equal(response.cached, true);
+  });
 });