Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new bug template #591

Merged
merged 15 commits into from
Jul 4, 2023
Merged

chore: new bug template #591

merged 15 commits into from
Jul 4, 2023

Conversation

Marcellofabrizio
Copy link
Contributor

This PR adds the GitHub bug Issue template as requested in #587.

Let me know of any sections that must be added.

@Marcellofabrizio Marcellofabrizio changed the title New bug template chore: new bug template Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #591 (0a7cb7b) into main (9db69b5) will not change coverage.
The diff coverage is n/a.

❗ Current head 0a7cb7b differs from pull request most recent head 23a2813. Consider uploading reports for the commit 23a2813 to get more accurate results

@@            Coverage Diff            @@
##              main      #591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          578       578           
  Branches       190       190           
=========================================
  Hits           578       578           

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
- type: input
id: node_version
attributes:
label: Node Version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: Node Version
label: Node / Browser version

id: node_version
attributes:
label: Node Version
description: What version of Node.js are you running?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: What version of Node.js are you running?
description: What version of Node.js/Browser are you running?

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@arthurfiorette
Copy link
Owner

arthurfiorette commented Jul 4, 2023

Suuuuper thanks for your work!!! Merging as soon as these are changed.

@Marcellofabrizio
Copy link
Contributor Author

Suuuuper thanks for your work!!! Merging as soon as these are changed.

Sure, I'll make these changes latter this evening

@Marcellofabrizio
Copy link
Contributor Author

@arthurfiorette I did the changes you commented about. Seems we are good now.

Let me know if there is anything else!

@Marcellofabrizio
Copy link
Contributor Author

Actually thinking about it, should the Storage Type field be required @arthurfiorette ?

@arthurfiorette
Copy link
Owner

@Marcellofabrizio I think so, as you cannot use without one.

@Marcellofabrizio
Copy link
Contributor Author

@arthurfiorette I removed the required field from the Storage type

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
@arthurfiorette
Copy link
Owner

Merging it now! Thanks for your effort!

@arthurfiorette arthurfiorette merged commit 95f1d8d into arthurfiorette:main Jul 4, 2023
@arthurfiorette arthurfiorette linked an issue Jul 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change issues template to Github Issue Forms
2 participants