Add: custom variable for minitest spring command #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenAnnard
force-pushed
the
spring_improvements
branch
3 times, most recently
from
d9173c8
to
8af65fa
Compare
Since we may need a different (i.e. non-standard) way of executing the tests, this patch makes it configurable.
ZenAnnard
force-pushed
the
spring_improvements
branch
from
54f265a
to
638adc0
Compare
gcentauri
requested changes
Dec 27, 2019
There was a problem hiding this comment.
Thanks for the PR! ❤️
Just a minor indentation issue, and it might be useful to add another assertion to test-minitest-test-command just to ensure we get the expected Spring command when the variable is customized. I know its technically already being tested, but it can't hurt :)
Improved indentation (my fault, aplogies). Improved test to explicitly test new customisation variable.
|
Thank you for taking a look at my PR! |
gcentauri
requested changes
Dec 29, 2019
gcentauri
approved these changes
Dec 29, 2019
gcentauri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it configurable by allowing the spring command to be configured externally through the variable
minitest-spring-command.This is useful if you have a complicated spring workflow like we have at Zendesk.