Derive Hash, PartialEq, Eq, PartialOrd, Ord on mersenne twister RNGs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a statement documenting `rand_mt`'s minimum supported Rust version to the README. - Bump the MSRV to 1.47.0, which lifted the `LengthAtMost32` restriction on generic array length impls. - Add a (unenforced) CI job for testing `rand_mt` with Rust 1.47.0. - Derive `Hash`, `PartialEq`, `Eq`, `PartialOrd`, `Ord` on `Mt19937GenRand32`. - Derive `Hash`, `PartialEq`, `Eq`, `PartialOrd`, `Ord` on `Mt19937GenRand34`. - Remove the `write!` macro from the `core::fmt::Debug` impls on `Mt19937GenRand32` and `Mt19937GenRand64`, preferring to use `fmt::Formatter::write_str` instead.
lopopolo
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand_mt's minimum supported Rust versionto the README.
LengthAtMost32restrictionon generic array length impls.
rand_mtwith Rust 1.47.0.Hash,PartialEq,Eq,PartialOrd,OrdonMt19937GenRand32.Hash,PartialEq,Eq,PartialOrd,OrdonMt19937GenRand34.write!macro from thecore::fmt::Debugimpls onMt19937GenRand32andMt19937GenRand64, preferring to usefmt::Formatter::write_strinstead.