feat: env file improvements #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the values set in an env file are only made available to the Artillery process running in a worker Azure, instead of being set at the container level. This means that for example it's impossible to set the DEBUG environment variable in the worker to help debug issues. This change makes tests on Azure ACI work in the same way as tests on AWS Fargate.
Add --env-file as an alias for the existing --dotenv flag. "--dotenv" is a confusing name when saying it out loud (e.g. on a support call). "--env-file" is more precise and is also used by Node.js v20 and above: https://nodejs.org/dist/latest-v20.x/docs/api/cli.html#--env-fileconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--dotenvavailable to workers on Azure--env-fileas an alias for--dotenvPre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.