Clarify testing prerequisites in readme and fix tests #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cornytrace
force-pushed
the
readme
branch
3 times, most recently
from
f2a9a79 to
ccfb9e4
Compare
Generated files are more correct without regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies how to link the project to its own node_modules so that the composite test suite can complete successfully. This took me a while to figure out, so I would like to spare others the trouble.
This also fixes a runtime error in emitter that would prevent the tests from completing.
It also fixed the paths to classBound and bound being generated as "undefinedclassBound"