-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render selection feature #26
Comments
I love the idea! Let me know if this is good for you. |
Wow! That's more than I could have dreamed it would be. So cool! I can see myself wearing holes into that context menu item! I only noticed one thing missing. It seems like highlight.js doesn't get loaded in this scenario. Would you be able to enable that? |
Should be better with this commit |
Awesome! I'll try it out! |
Works great! I sent a pull request to update highlight.js to include support for additional languages (such as AsciiDoc) and to switch to the default highlight.js theme, which I think looks a bit better w/ the Asciidoctor theme. Down the road, we probably want to make the highlight.js theme configurable. |
Also, highlight.js has this annoying feature that it will try to detect the closest next language if the language specified doesn't match one it knows about. This almost always leads to incorrect syntax highlighting. Better just to not highlight in this case. |
@mojavelinux Can we close this issue ? |
Indeed! It works great! |
When viewing a web page, I'd like to be able to select a region of text and have Asciidoctor.js render it in a new tab or window. With this capability, I could pick out a reply on a mailinglist thread that was written in the AsciiDoc syntax and view the content in all its glory without having to go through the exercise of saving it to a file, etc.
The text was updated successfully, but these errors were encountered: