resolves #35 automatically register converter and extension #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
force-pushed
the
issue-35-load-converter
branch
from
ee501c3 to
723c907
Compare
ggrossetie
changed the title
|
I will go ahead and merge this pull request (and resolve conflicts of course 😉) |
ggrossetie
force-pushed
the
issue-35-load-converter
branch
from
723c907 to
66c3864
Compare
ggrossetie
force-pushed
the
issue-35-load-converter
branch
from
66c3864 to
8d25a48
Compare
ggrossetie
force-pushed
the
issue-35-load-converter
branch
from
8d25a48 to
11a10fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already discussed this issue with @mojavelinux but I think we should try to automatically register converters and extensions using a well defined API.
As mentioned in the code, currently we have a "conflict" in the API. Both converters and extensions are using the
registerfunction. But theregisterfunction used in extensions expects one argument (the extension registry) while theregisterfunction used in converters does not take any argument.