-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #349 create HTML from IDE using an editor action #354
Conversation
Thank you for your pull request - looks great! Thank you for including docs and tests already. Please have a look at the following elements:
Please have a look. After the change it will be ready to merge. |
@ahus1 I'm facing trouble with including font-awesome css file to the export. The exported html file needs font-awesome css file for the icons. |
The convertFile() method will add the font awesome icon if (and only if) you set the icons attribute. It will include a link to a file on the CDN. The following example works for me:
From my point of view it is now ready to be merged. Let me know if you agree; I'll then squash-and-merge the change. |
Please go ahead and merge the change. |
Thank you for this pull request to add this new functionality! I hope the documentation like the contribution guide helped. Let me know if you missed something or think something could be improved for contributors. |
@ahus1 Thanks for the excellent support that you have provided. The contribution document is so helpful for the new contributors like me right from setting up the environment, running tests till the development of the plugin. This is my first pull request in my entire development career. I would like to contribute more to the community. Once again thank you so much for the support you provided. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing documents:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature:
Other information:
fixes #349