Tables do not listen to "grid" and "frames" options

[wackywendell]

Try this with asciidoctor with and without this backend:

[grid="all",frame="all",options="header"]
|==========================
| Test | Test 2 | Test 3
| More | Again  | And again
|==========================

The grid and frame shows up for regular asciidoctor, but not with reveal.js. It seems that there are some classes missing:

table.grid-all th.tableblock,table.grid-all td.tableblock{border-width:0 1px 1px 0}
table.grid-all tfoot>tr>th.tableblock,table.grid-all tfoot>tr>td.tableblock{border-width:1px 1px 0 0}
table.grid-cols th.tableblock,table.grid-cols td.tableblock{border-width:0 1px 0 0}
table.grid-all *>tr>.tableblock:last-child,table.grid-cols *>tr>.tableblock:last-child{border-right-width:0}
table.grid-rows th.tableblock,table.grid-rows td.tableblock{border-width:0 0 1px 0}
table.grid-all tbody>tr:last-child>th.tableblock,table.grid-all tbody>tr:last-child>td.tableblock,table.grid-all thead:last-child>tr>th.tableblock,table.grid-rows tbody>tr:last-child>th.tableblock,table.grid-rows tbody>tr:last-child>td.tableblock,table.grid-rows thead:last-child>tr>th.tableblock{border-bottom-width:0}
table.grid-rows tfoot>tr>th.tableblock,table.grid-rows tfoot>tr>td.tableblock{border-width:1px 0 0 0}
table.frame-all{border-width:1px}
table.frame-sides{border-width:0 1px}
table.frame-topbot{border-width:1px 0}

Those rules show up in the regular asciidoctor document, but not the asciidoctor-reveal.js one.

[wackywendell]

Also... I hope I'm not being too annoying. I'm really enjoying using this backend, and its really useful - there aren't many presentation options out there that are 1) portable, 2) easy, 3) can handle math even inline, and 4) can handle videos. This can do that, which makes it pretty impressive! Thank you for making this work!

[mojavelinux]

I hope I'm not being too annoying.

Please don't think that. We need motivated developers like yourself to keep this moving forward! Thanks!

[mojavelinux]

there aren't many presentation options out there that are 1) portable, 2) easy, 3) can handle math even inline, and 4) can handle videos.

Don't forget charts! See https://github.com/asciidoctor/asciidoctor-extensions-lab/blob/master/lib/chart-block-macro.rb (we still need to integrate it into the backend, but the work to create it has been done).

[mojavelinux]

Those rules show up in the regular asciidoctor document, but not the asciidoctor-reveal.js one.

What we need to do is inject common CSS for styling AsciiDoc components into the output so that features such as table alignment and borders work regardless of which theme you are using. Ideally, the Asciidoctor stylesheet factory should be able to produce this common CSS, but for now we can assemble it manually to get it working.

[obilodeau]

This will be part of our upcoming 3.0.0 release.