Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we bump to latest MathJax 2.7.x? #355

Closed
obilodeau opened this issue Mar 16, 2020 · 3 comments · Fixed by #361
Closed

Should we bump to latest MathJax 2.7.x? #355

obilodeau opened this issue Mar 16, 2020 · 3 comments · Fixed by #361
Labels
🎤 discussion Items that needs to be discussed with the broader Asciidoctor community
Milestone

Comments

@obilodeau
Copy link
Member

Request for comments

MathJax 2.4 is about to be 6 years old. The latest stable release 2.7.5 is 2 years old. It seems pretty stable. Trying the example that @akosma provided with it worked.

Release notes of in-between versions don't reveal any backward-incompatible changes:

I think we should update our default version to 2.7.5 given that it seems backward-compatible, any objections?

@obilodeau obilodeau added this to the 4.1.0 milestone Mar 16, 2020
@obilodeau obilodeau added the 🎤 discussion Items that needs to be discussed with the broader Asciidoctor community label Mar 16, 2020
@obilodeau obilodeau changed the title RFC: Bump to MathJax 2.7 Should we bump to MathJax 2.7.5? Mar 16, 2020
@akosma
Copy link
Contributor

akosma commented Mar 17, 2020

I think it's a good idea to update.

@obilodeau obilodeau modified the milestones: 4.2.0, 5.0.0, 4.1.0 Mar 19, 2020
@ggrossetie
Copy link
Member

I cannot attest that 2.7.5 is 100% backward compatible but I think we should upgrade.
We should even consider upgrading to MathJax 3 but that's another subject 😉

obilodeau added a commit to obilodeau/asciidoctor-reveal.js that referenced this issue Mar 24, 2020
@obilodeau obilodeau linked a pull request Mar 24, 2020 that will close this issue
@obilodeau obilodeau changed the title Should we bump to MathJax 2.7.5? Should we bump to latest MathJax 2.7.x? May 27, 2020
@obilodeau
Copy link
Member Author

So, since the associated PR was posted, MathJax is at 2.7.8. However, in the meantime they released MathJax 3. I'm not willing to move to MathJax 3 especially now that revealjs introduced v4 which means that we are heading towards a major release to support it anyway which would be a perfect time to move MathJax to v3.

However, thinking about stability, cloudflare doesn't host MathJax 2.7.8 and since cdn_base is used to resolve several CSS and JS dependencies, I don't want to break it apart now. I'm going to reluctantly merge a mathjax 2.7.6 support and open a ticket on a move to v3 along with reveal.js 4.

obilodeau added a commit that referenced this issue May 27, 2020
Updated Mathjax to latest version available (fixes #355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎤 discussion Items that needs to be discussed with the broader Asciidoctor community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants