-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #276 add the kdb style #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring with adding new functionality in a single commit makes it harder to assess if there's no regression silently introduced. Try to split both next time around.
I will diff the files with master once this is rebased to make sure nothing was reverted by mistake (since we touched the CSS along the way).
I can split the changes no worries. |
This was done in #330 and merged. Time to rebase 🙂 |
bb23fba
to
c465894
Compare
@obilodeau Done! I've edited my first comment to add a screenshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Can you add that example in examples/
and generate the appropriate doctest, please?
@obilodeau There's already an example and a doctest named "keyboard-shortcuts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obilodeau There's already an example and a doctest named "keyboard-shortcuts"
Did I say something? 😉
Here's how it looks: