Fixes #299: Removed rerouting of System.out and System.err to JUL #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
lordofthejars
added a commit
that referenced
this pull request
May 8, 2015
Fixes #299: Removed rerouting of System.out and System.err to JUL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution to capture output from Asciidoctor and route it to a Java logger leads to infinite recursions and therefore StackOverflows when a ConsoleHandler is configured, which is the default in most configurations.
This problem is not reproducable with gradle as it replaces the normal System.out and System.err fields with own streams.
As Dan pointed out in #299 Asciidoctor will provide another solution that allows for capturing the output without having to read from System.out.
Therefore this PR completely removes capturing System.out and .err without replacement.