Fixes #942. When an Asciidoctor instance is created with a classloade… #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classloader parameter, use this classloader also to autoregister extensions, converters, syntax highlighters and loggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r parameter, use this classloader also to autoregister extensions, converters, syntax highlighters and loggers.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
When an Asciidoctor instance is created with AsciidoctorJRuby.create(ClassLoader), the given classloader should not also be used to let JRuby find the Asciidoctor gem, but also to auto register extensions etc.
Are there any alternative ways to implement this?
Possibly.
Are there any implications of this pull request? Anything a user must know?
Yes!
This should be thoroughly tested in the different environments like the gradle plugin, maven plugin and Osgi, as all of these environments might behave differently wrt class loading.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #942
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc