Remove Kindlegen gem #160
Merged
Remove Kindlegen gem #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dduportal <[email protected]>
Merged
slonopotamus
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
As of today, dropping dependency on kindlegen gem is a way to go. Obviously, this means that Mobi generation is no longer available. A new working solution is expected to be done in asciidoctor/asciidoctor-epub3#363.
|
It actually means that asciidoctor-docker was violating KindleGen EULA by distributing KindleGen binary in docker images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @slonopotamus in tdtds/kindlegen#42 and asciidoctor/asciidoctor-epub3#363, the binaries for
kindlegenare no longer available.As it breaks the build (the gem installation of the ruby Gem
kindlegenfails when downloading this binary),this PR remove the dependency to the
kindlegenRuby Gem.Signed-off-by: dduportal [email protected]