Change default-gems path to be relative to ASDF_CONFIG_FILE #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stratus3D any chance you'd be able to merge this? |
|
@Stratus3D just wondering if you had any feedback on this PR? |
|
For anyone reviewing this, it seems there is a discussion about approaching this at the asdf level rather than individual plugins located here asdf-vm/asdf#687 |
|
I think this can be closed because #212 has been merged. |
|
Closing because #212 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the path to the
default-gemsfile so that asdf-ruby now looks for it in the same directory as theasdfrc. It now checks fordefault-gemsand.default-gemsin that directory and then falls back to the current value of${HOME}/.default-gems.