test: Improve Elvish tests #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
force-pushed
the
fix-tests
branch
4 times, most recently
from
85eab88
to
bd89e8b
Compare
hyperupcall
changed the title
jthegedus
approved these changes
Jan 9, 2023
|
Good point - likely will Related to #1351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Old versions of Elvish cause spectacular failures
My patches fix that:
The module handling was also improved. Rather than copying the
adsf.elvfile and munging with user config files (which was already broken in cases where$XDG_CONFIG_HOMEwas not set to$HOME/.config), it uses the files in place by using relative imports. Additionally,XDG_CONFIG_HOMEandXDG_DATA_HOME, etc. were set to empty so user config files are never parsed (it seems the-norcflag of Elvish is limited), improving test isolation.