Move tasks code inside entry files #421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves tasks code inside entry files. Removes the
tasks
folder.Related to #404
Motivation:
Drawbacks:
@hydra.main
decorated functionpyrootutils.setup_root()
now gets executed every time the task method is imported in other files (which can happen in tests) because the line must be placed at the beginning of the file. This shouldn't break the tests though as far as I'm aware.Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Always 🙃