Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit config updates for jupyter notebooks and flake8 W503 #435

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

atong01
Copy link
Contributor

@atong01 atong01 commented Sep 5, 2022

What does this PR do?

Fixes #434

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
    Could be separated into two PRs, but very small changes.
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Base: 84.59% // Head: 84.59% // No change to project coverage 👍

Coverage data is based on head (8d1beb3) compared to base (a98ead1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files           9        9           
  Lines         344      344           
=======================================
  Hits          291      291           
  Misses         53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashleve
Copy link
Owner

ashleve commented Sep 7, 2022

Thanks a lot for looking into this and making a PR! These are very welcomed improvements for pre-commit.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@ashleve
Copy link
Owner

ashleve commented Sep 7, 2022

Added a small explanation comment to nbQA

@ashleve ashleve merged commit 2f3fe86 into ashleve:main Sep 7, 2022
@ashleve
Copy link
Owner

ashleve commented Sep 7, 2022

@atong01 Merged! Thank you for the contribution :)

@ashleve ashleve added bug Something isn't working enhancement New feature or request labels Sep 7, 2022
@ashleve ashleve added maintenance and removed bug Something isn't working labels Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved pre-commit config: Jupyter Notebook linting, black incompatibility
3 participants