Disable ignoring net in mnist module

[ashleve]

What does this PR do?

Disables ignoring net object in mnist module.

Originally we were ignoring it since lightning was displaying a warning that net parameters will be stored in ckpt either way, but it turns out user is not able to load MNISTLitModule from ckpt as easily when net is ignored.

When not ignoring net, we can load model from ckpt with MNISTLitModule.load_from_checkpoint(...) and it works out of the box (without the need to additionally provide the net object as call argument).

Should be less confusing for users.

Fix #456

Before submitting

• Did you make sure title is self-explanatory and the description concisely explains the PR?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you list all the breaking changes introduced by this pull request?
• Did you test your PR locally with pytest command?
• Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

[codecov-commenter]

Codecov Report

Base: 84.46% // Head: 84.46% // No change to project coverage 👍

Coverage data is based on head (91ac00a) compared to base (28386d6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files           9        9           
  Lines         354      354           
=======================================
  Hits          299      299           
  Misses         55       55           

Impacted Files	Coverage Δ
src/models/mnist_module.py	98.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.