Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor utils #541

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Refactor utils #541

merged 6 commits into from
Mar 18, 2023

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented Feb 25, 2023

What does this PR do?

Significant utility folder refactor

  1. Splitted utils.py to several files
  2. Moved utils.extras() call from task wrapper to main() in entry files. This makes task wrapper solely responsible for managing behavior during failure, which I think has more sense than using it to apply a bunch of random utilties

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Patch coverage: 55.12% and project coverage change: +0.33 🎉

Comparison is base (8bd98d6) 83.66% compared to head (8f007e6) 84.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #541      +/-   ##
==========================================
+ Coverage   83.66%   84.00%   +0.33%     
==========================================
  Files           9       11       +2     
  Lines         349      350       +1     
==========================================
+ Hits          292      294       +2     
+ Misses         57       56       -1     
Impacted Files Coverage Δ
src/eval.py 87.50% <0.00%> (-2.83%) ⬇️
src/utils/logging_utils.py 19.23% <19.23%> (ø)
src/utils/utils.py 72.09% <56.25%> (+12.28%) ⬆️
src/utils/instantiatiators.py 80.64% <80.64%> (ø)
src/train.py 95.91% <100.00%> (ø)
src/utils/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashleve ashleve merged commit 8864d46 into dev Mar 18, 2023
@ashleve ashleve deleted the utils branch March 18, 2023 16:32
ashleve added a commit that referenced this pull request Mar 18, 2023
* Support for logging with Aim (#534)

* Update template to Lightning 2.0 (#548)

* Update pre-commit hooks (#549)

* Refactor utils (#541)

* Add option for pytorch 2.0 model compilation (#550)

* Update `README.md` (#551)

---------

Co-authored-by: Mattie Tesfaldet <[email protected]>
Co-authored-by: Johnny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants