Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing yaml extension from hydra config names in defaults lists. #584

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

tesfaldet
Copy link
Contributor

What does this PR do?

Fixes #420.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

👍

@tesfaldet
Copy link
Contributor Author

Tests can be fixed from this PR #585

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (9355a5d) 83.66% compared to head (b86feb5) 83.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files          11       11           
  Lines         355      355           
=======================================
  Hits          297      297           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ashleve ashleve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this ❤️

@ashleve ashleve merged commit b987605 into ashleve:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

According to hydra documentation config names should not have .yaml extension
3 participants