-
Notifications
You must be signed in to change notification settings - Fork 269
Update template rendering and update_attributes for Rails 6.1; adds Appraisals for Rails 6.0 and 6.1 #366
Conversation
c749872
to
eb8abdc
Compare
Hey @phillbaker. Maybe I will fix the specs and we will merge that? |
👋 I'm not actively working on this open source project any more. @assaf I'm not sure if you've given other folks contributor access to this repo, if not, let's maybe open an issue and ask for volunteers? |
That would be nice! |
I have repository access, but not to release on Rubygems. I can pick this up again if no one else is quicker to overcome the challenges. |
@frostmark that would be fantastic if you can get this passing in local development. I opened up #369 to try to get CI running again on the project. |
I do have access to add you on ruby gems, can your confirm your username
there?
…On Tue, Jan 25, 2022 at 11:58 AM bensheldon ***@***.***> wrote:
@frostmark <https://github.com/frostmark> that would be fantastic if you
can get this passing in local development.
I opened up #369 <#369> to try to get
CI running again on the project.
—
Reply to this email directly, view it on GitHub
<#366 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXCKN7FUAKR7ZFFMIBZSLUX3JBXANCNFSM4U2DEJIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
cbb29fe
to
dc076e8
Compare
Oops, I shouldn't have rebased this branch because I realized people have the old commit pinned 🤦 I just undid that so the original commit is in the branch. |
Tests are green; I tried it on my own application. I guess it's ready 🚀 |
That awesome! |
I released this on rubygems in v3.0.1 too 🥳 |
render file: ''
support for templates. This has been replaced withprepend_view_path
to include template root. There is a pre-existing TODO to convert to an Engine, which would clean this all right up.ActiveRecord::Base#update_attributes
; replaced with#update