Merge pull request #7 from asset-pipe/develop

fix: Ensure newline between concatenated CSS chunks
asset-pipe · Nov 1, 2017 · d6a07f0 · d6a07f0
2 parents 7a70836 + b2cd534
commit d6a07f0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/reader.js b/lib/reader.js
@@ -68,7 +68,7 @@ module.exports = class Reader extends Readable {
         this.data.pause();
 
         this.data.on('data', chunk => {
-            this.push(chunk.content);
+            this.push(`${chunk.content.trim()}\n\n`);
         });
 
         this.data.on('end', () => {

diff --git a/test/reader.test.js b/test/reader.test.js
@@ -243,9 +243,9 @@ test('new Reader([s1,s2,s3,s4]) ensure dedupe and correct css concat order', don
         reader.on('data', data => bundle.push(data.toString()));
         reader.on('end', () => {
             expect(bundle).toEqual([
-                '/* my-module-3/main.css */\n\n/* my-module-3/dep.css */\n\n/* dep/main.css */\n',
-                '/* my-module-2/main.css */\n',
-                '/* my-module-1/main.css */\n',
+                '/* my-module-3/main.css */\n\n/* my-module-3/dep.css */\n\n/* dep/main.css */\n\n',
+                '/* my-module-2/main.css */\n\n',
+                '/* my-module-1/main.css */\n\n',
             ]);
             done();
         });
@@ -275,9 +275,9 @@ test('new Reader([s1,s2,s3,s4]) operates correctly under slow speed conditions',
         reader.on('data', data => bundle.push(data.toString()));
         reader.on('end', () => {
             expect(bundle).toEqual([
-                '/* my-module-3/main.css */\n\n/* my-module-3/dep.css */\n\n/* dep/main.css */\n',
-                '/* my-module-2/main.css */\n',
-                '/* my-module-1/main.css */\n',
+                '/* my-module-3/main.css */\n\n/* my-module-3/dep.css */\n\n/* dep/main.css */\n\n',
+                '/* my-module-2/main.css */\n\n',
+                '/* my-module-1/main.css */\n\n',
             ]);
             done();
         });