Forwardport release 1.2 into master #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pavinati
commented
Nov 7, 2024
Pavinati
commented
Use JSON.stringify for all types of values and not only objects. This will change the behaviour of all the values shown in the component, now all of them are JSON values (e.g. string with `"`, `false` values), before React wouldn't have shown `false`, empty arrays or strings. Signed-off-by: Joshua Chapman <[email protected]>
…e-events fix(DeviceLiveEventsCard): show falsey values
Resolved an issue in the Highlight component where the search filter term was appended to the displayed `Device ID` and `Alias` fields. Updated the component to use a regular expression for correctly highlighting the search term without modifying the original device information. Signed-off-by: Omar <[email protected]>
…ght_filter_append_issue Fix highlight component to avoid appending filter term to device info
Signed-off-by: Mattia Pavinati <[email protected]>
…ease-1.1-into-1.2 Forwardport release 1.1 into 1.2
davidebriani
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.