refactor(trigger_engine): port query to xandra #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test(trigger_engine): await xandra cluster before starting tests Signed-off-by: Francesco Noacco <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
==========================================
- Coverage 67.42% 67.36% -0.07%
==========================================
Files 264 264
Lines 6429 6432 +3
==========================================
- Hits 4335 4333 -2
- Misses 2094 2099 +5
|
Annopaolo
requested changes
Sep 4, 2023
| trigger <- Trigger.decode(trigger_data), | ||
| {:ok, action} <- Jason.decode(trigger.action) do | ||
| {:ok, action} | ||
| else | ||
| {:error, :database_connection_error} -> | ||
| Logger.warn("Database connection error.") | ||
| {:error, %Xandra.ConnectionError{action: action, reason: reason}} -> |
There was a problem hiding this comment.
The {:error, %Xandra.Error{}} case is not handled. It would be good to keep database and logic error (e.g. trigger not found) distinct
| if Astarte.Core.Realm.valid_name?(realm_name) do | ||
| :ok | ||
| else | ||
| {:error, :realm_not_found, realm_name} |
There was a problem hiding this comment.
I'd say to use a more explicit :invalid_realm_name atom
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Show resolved
Hide resolved
noaccOS
force-pushed
the
trigger_engine-xandra
branch
from
bd74ded
to
48c8cdc
Compare
noaccOS
force-pushed
the
trigger_engine-xandra
branch
2 times, most recently
from
6bd7516
to
89a1fc9
Compare
Annopaolo
requested changes
Sep 5, 2023
apps/astarte_trigger_engine/lib/astarte_trigger_engine/application.ex
Outdated
Show resolved
Hide resolved
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Outdated
Show resolved
Hide resolved
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Outdated
Show resolved
Hide resolved
apps/astarte_trigger_engine/lib/astarte_trigger_engine/config.ex
Outdated
Show resolved
Hide resolved
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Show resolved
Hide resolved
noaccOS
force-pushed
the
trigger_engine-xandra
branch
from
89a1fc9
to
3bfab10
Compare
feat(trigger_engine): tag connection_error log Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
trigger_engine-xandra
branch
from
3bfab10
to
71f8dd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yes there was only one query
closes #459