Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cassandra port binding #998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shinnokdisengir
Copy link
Contributor

@shinnokdisengir shinnokdisengir commented Oct 3, 2024

What this PR does / why we need it:

In order to local develop astarte via dev mode, using astarte-dev-tool up or using docker compose watch, cassandra/scylla needs to expose the port used to connection. Otherwise, the connection are only available via cluster.

With this PR scylla/cassandra is exposed on localhost:9042

Copy link
Collaborator

@Annopaolo Annopaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems with DCO

docker-compose.dev.yml Outdated Show resolved Hide resolved
@shinnokdisengir shinnokdisengir force-pushed the feature/cassandra-port-binding branch 2 times, most recently from 7aaf22e to 1bb43d1 Compare October 7, 2024 13:14
Copy link
Collaborator

@Annopaolo Annopaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good! Please, provide some more context in the commit (and PR title) and we're ready to go!

In order to _local_ develop astarte via `dev mode`, using [`astarte-dev-tool up`](astarte-platform#978)  or using `docker compose watch`, cassandra/scylla needs to expose the port used to connection. Otherwise, the connection are only available via cluster.

With this PR scylla/cassandra is exposed on `localhost:9042`

Signed-off-by: Gabriele Ghio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants