Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace row/column based Location with byte-offsets. #3931

Merged
merged 21 commits into from
Apr 26, 2023
Merged

Replace row/column based Location with byte-offsets. #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
34e6296
Use local RustPython branch with byte offsets
MichaReiser Mar 31, 2023
552a26e
Add methods on `Edit` that accept `TextRange`
MichaReiser Apr 14, 2023
be00564
Clippy
MichaReiser Apr 14, 2023
22b116d
Use rustpython from git
MichaReiser Apr 14, 2023
ddf3672
Make stylist less lazy
MichaReiser Apr 15, 2023
c5b3c58
Show line/column numbers for syntax errors
MichaReiser Apr 17, 2023
5c4a3e3
Fix add_rule script
MichaReiser Apr 17, 2023
8b9c9f4
Use Indent offsets
MichaReiser Apr 17, 2023
ff55025
Lazy compute source file line index
MichaReiser Apr 17, 2023
bd38594
Delete PLC0999.py
MichaReiser Apr 17, 2023
c6c540b
Cargo fmt
MichaReiser Apr 17, 2023
f6a02e7
Fix add_rule script
MichaReiser Apr 17, 2023
4ba63e4
Fix column in playground
MichaReiser Apr 18, 2023
1601f60
Fix line too long column number, ...
MichaReiser Apr 18, 2023
bf1789b
fix invalid escape sequence at end of file, sort messages by kind
MichaReiser Apr 18, 2023
7b657bb
Revert one-indexed columns for JSON ouptut
MichaReiser Apr 19, 2023
8c81e50
Undo visibility change
MichaReiser Apr 23, 2023
bd586ef
Address code-review feedback
MichaReiser Apr 23, 2023
6ebe212
Fix noqa handling
MichaReiser Apr 23, 2023
7893968
Fix byte offset errors
MichaReiser Apr 23, 2023
7336d55
Upgrade RustPython Parser
MichaReiser Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ indent_size = 2

[*.{rs,py}]
indent_size = 4

[*.snap]
trim_trailing_whitespace = false
36 changes: 13 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,10 @@ path-absolutize = { version = "3.0.14" }
proc-macro2 = { version = "1.0.51" }
quote = { version = "1.0.23" }
regex = { version = "1.7.1" }
ruff_text_size = { git = "https://github.com/charliermarsh/RustPython.git", rev = "c3147d2c1524ebd0e90cf1c2938d770314fd5a5a" }
rustc-hash = { version = "1.1.0" }
rustpython-common = { git = "https://github.com/RustPython/RustPython.git", rev = "c15f670f2c30cfae6b41a1874893590148c74bc4" }
rustpython-parser = { features = [
"lalrpop",
"serde",
], git = "https://github.com/RustPython/RustPython.git", rev = "c15f670f2c30cfae6b41a1874893590148c74bc4" }
rustpython-common = { git = "https://github.com/charliermarsh/RustPython.git", rev = "c3147d2c1524ebd0e90cf1c2938d770314fd5a5a" }
rustpython-parser = { git = "https://github.com/charliermarsh/RustPython.git", rev = "c3147d2c1524ebd0e90cf1c2938d770314fd5a5a" }
schemars = { version = "0.8.12" }
serde = { version = "1.0.152", features = ["derive"] }
serde_json = { version = "1.0.93", features = ["preserve_order"] }
Expand Down
4 changes: 2 additions & 2 deletions crates/ruff/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ name = "ruff"
ruff_cache = { path = "../ruff_cache" }
ruff_diagnostics = { path = "../ruff_diagnostics", features = ["serde"] }
ruff_macros = { path = "../ruff_macros" }
ruff_python_ast = { path = "../ruff_python_ast" }
ruff_python_ast = { path = "../ruff_python_ast", features = ["serde"] }
ruff_python_semantic = { path = "../ruff_python_semantic" }
ruff_python_stdlib = { path = "../ruff_python_stdlib" }
ruff_rustpython = { path = "../ruff_rustpython" }
ruff_text_size = { path = "../ruff_text_size" }
ruff_text_size = { workspace = true }

annotate-snippets = { version = "0.9.1", features = ["color"] }
anyhow = { workspace = true }
Expand Down
3 changes: 3 additions & 0 deletions crates/ruff/resources/test/fixtures/pycodestyle/W505.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ def f():

# Here's a standalone comment that's over the limit.

x = 2
# Another standalone that is preceded by a newline and indent toke and is over the limit.

print("Here's a string that's over the limit, but it's not a docstring.")


Expand Down
Loading