Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applicability to pandas_vet #5252

Merged

Conversation

evanrittenhouse
Copy link
Contributor

Summary

Fixes part of #4184

Test Plan

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.03      6.7±0.02ms     6.1 MB/sec    1.00      6.5±0.01ms     6.3 MB/sec
formatter/numpy/ctypeslib.py               1.02   1377.7±1.75µs    12.1 MB/sec    1.00   1354.1±6.73µs    12.3 MB/sec
formatter/numpy/globals.py                 1.01    132.5±0.16µs    22.3 MB/sec    1.00    131.5±1.66µs    22.4 MB/sec
formatter/pydantic/types.py                1.05      2.8±0.01ms     9.2 MB/sec    1.00      2.6±0.01ms     9.7 MB/sec
linter/all-rules/large/dataset.py          1.00     13.1±0.04ms     3.1 MB/sec    1.01     13.2±0.05ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.01ms     5.0 MB/sec    1.01      3.3±0.01ms     5.0 MB/sec
linter/all-rules/numpy/globals.py          1.03    439.0±2.61µs     6.7 MB/sec    1.00    427.7±0.73µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.8±0.02ms     4.4 MB/sec    1.01      5.9±0.04ms     4.4 MB/sec
linter/default-rules/large/dataset.py      1.00      6.6±0.01ms     6.2 MB/sec    1.02      6.7±0.01ms     6.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1450.0±1.86µs    11.5 MB/sec    1.02   1475.7±8.87µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    162.9±0.46µs    18.1 MB/sec    1.02    166.9±1.16µs    17.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.00ms     8.5 MB/sec    1.02      3.1±0.01ms     8.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.9±0.11ms     5.2 MB/sec    1.00      7.9±0.10ms     5.2 MB/sec
formatter/numpy/ctypeslib.py               1.00  1579.9±18.09µs    10.5 MB/sec    1.01  1597.9±21.17µs    10.4 MB/sec
formatter/numpy/globals.py                 1.00    157.3±4.09µs    18.8 MB/sec    1.00    157.4±4.15µs    18.7 MB/sec
formatter/pydantic/types.py                1.02      3.3±0.04ms     7.8 MB/sec    1.00      3.2±0.05ms     7.9 MB/sec
linter/all-rules/large/dataset.py          1.01     16.1±0.25ms     2.5 MB/sec    1.00     15.9±0.32ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.01      4.2±0.08ms     4.0 MB/sec    1.00      4.1±0.07ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01   505.0±16.83µs     5.8 MB/sec    1.00    499.5±7.12µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.13ms     3.6 MB/sec    1.03      7.2±0.23ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.01      8.1±0.16ms     5.0 MB/sec    1.00      8.0±0.12ms     5.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1724.8±25.19µs     9.7 MB/sec    1.00  1713.8±20.59µs     9.7 MB/sec
linter/default-rules/numpy/globals.py      1.01    196.0±3.79µs    15.1 MB/sec    1.00    194.7±6.20µs    15.2 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.6±0.05ms     7.0 MB/sec    1.00      3.6±0.10ms     7.0 MB/sec

@charliermarsh charliermarsh enabled auto-merge (squash) June 21, 2023 16:59
@charliermarsh charliermarsh merged commit 2b76d88 into astral-sh:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants