Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --with-editable in uv tool install #7528

Closed
gaborbernat opened this issue Sep 19, 2024 · 5 comments · Fixed by #8472
Closed

Support --with-editable in uv tool install #7528

gaborbernat opened this issue Sep 19, 2024 · 5 comments · Fixed by #8472
Labels
cli Related to the command line interface enhancement New feature or improvement to existing functionality help wanted Contribution especially encouraged

Comments

@gaborbernat
Copy link
Contributor

gaborbernat commented Sep 19, 2024 •
edited
Loading

Would it be possible to specify the editable flag for the with options too? Something like:

 uv tool install -e tox@/Users/bernat/git/github/tox  \
					   --with-editable tox-uv@/Users/bernat/git/github/tox-uv  \
						--force-reinstall --force
@charliermarsh
Copy link
Member

Yeah I think this probably should exist, it may be an oversight \cc @zanieb in case you know otherwise.

@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality help wanted Contribution especially encouraged cli Related to the command line interface labels Sep 19, 2024
@zanieb
Copy link
Member

zanieb commented Sep 19, 2024 •
edited
Loading

Yeah I presumed the contribution at #6744 did this but it only was uv tool run.

cc @kyoto7250 if you're interested.

@zanieb zanieb changed the title uv tool with editable Support --with-editable in uv tool install Sep 19, 2024
@kyoto7250
Copy link
Contributor

@zanieb
Let me work on it!

@kyoto7250
Copy link
Contributor

kyoto7250 commented Sep 27, 2024 •
edited
Loading

I'll be able to publish a PR on the weekend.
It may be more difficult than originally estimated. I am continuing to work on this.

@kyoto7250
Copy link
Contributor

I still have the will to work on this issue, but I've been busy with work for a while, so I don't think I'll be able to do it this month.

If there is someone who is interested, it would be nice if that person could be in charge.

@blueraft blueraft mentioned this issue Oct 22, 2024
Merged
charliermarsh pushed a commit that referenced this issue Oct 23, 2024
@blueraft @zanieb
Support --with-editable in uv tool install (#8472)
82df00a 
## Summary

Closes #7528

## Test Plan

`cargo test`

---------

Co-authored-by: Zanie Blue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Related to the command line interface enhancement New feature or improvement to existing functionality help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support --with-editable in uv tool install blueraft/uv
4 participants
@gaborbernat @charliermarsh @zanieb @kyoto7250