Check python pin compatibility with Requires-Python
#4989
Conversation
zanieb
added
enhancement
blueraft
force-pushed
the
python-pin-compatibility
branch
from
ab6ab5b to
f8cfdcf
Compare
|
I took a closer look and have some more substantive requested changes. Let me know if you have questions or if the scope is too big. |
blueraft
force-pushed
the
python-pin-compatibility
branch
3 times, most recently
from
5bf20d9 to
107735d
Compare
blueraft
force-pushed
the
python-pin-compatibility
branch
from
a377c35 to
6eaa07d
Compare
|
Ah terrifying you force pushed while I was editing locally :) |
|
I'll make sure this is merged today |
AHH! Sorry, was trying the pull in main and fix the merge conflicts. You can take over the branch :) |
|
No problem haha it's your pull request! I'll take care of the remaining conflicts though :) thanks |
|
Thanks for being patient with this one! I made some important fixes as well as some simplifications the code and tweaks to messages — we could probably make factor the code into something further easier to read but it seems decent for now. |
|
Thanks for the thorough review! Appreciate it |
| Updated `.python-version` from `[email protected]` -> `cpython` | ||
|
|
||
| ----- stderr ----- | ||
| warning: The requested Python version `cpython` resolves to `3.10.[X]` which is incompatible with the project `Requires-Python` requirement of `>=3.12`. |
There was a problem hiding this comment.
Am I misunderstood or cpython must be resolved to 3.11? since context already contains it.
There was a problem hiding this comment.
Yes that's problematic. cc @charliermarsh looks like this regressed.
There was a problem hiding this comment.
This actually isn't a regression or related to #5205, we're just taking the first Python on the path. The problem here is that we need to respect Requires-Python on top of pinned version requests (😭).
Summary
Resolves #4969
Test Plan
cargo testand manual tests.