Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all special-casing for local version identifiers #8818

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Nov 4, 2024

Summary

After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.

@charliermarsh charliermarsh force-pushed the charlie/local branch 4 times, most recently from 34a20a8 to eec586a Compare November 4, 2024 23:34
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Nov 5, 2024
@charliermarsh charliermarsh marked this pull request as ready for review November 5, 2024 01:47
@charliermarsh charliermarsh added this to the v0.5.0 milestone Nov 5, 2024
@charliermarsh charliermarsh force-pushed the charlie/local branch 3 times, most recently from ebb096e to cb920e4 Compare November 5, 2024 22:40
@charliermarsh charliermarsh changed the base branch from main to tracking/050 November 6, 2024 03:19
@charliermarsh charliermarsh merged commit c0dde3c into tracking/050 Nov 6, 2024
62 checks passed
@charliermarsh charliermarsh deleted the charlie/local branch November 6, 2024 03:26
charliermarsh added a commit that referenced this pull request Nov 6, 2024
## Summary

After #8797, we have spec-compliant
handling for local version identifiers and can completely remove all the
special-casing around it.
@zanieb zanieb mentioned this pull request Nov 7, 2024
zanieb pushed a commit that referenced this pull request Nov 7, 2024
After #8797, we have spec-compliant
handling for local version identifiers and can completely remove all the
special-casing around it.
zanieb pushed a commit that referenced this pull request Nov 7, 2024
After #8797, we have spec-compliant
handling for local version identifiers and can completely remove all the
special-casing around it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant