Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using --build-backend in uv init implies --package #8837

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Using --build-backend in uv init implies --package #8837

merged 1 commit into from
Nov 5, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 5, 2024

No description provided.

@zanieb zanieb added the bug Something isn't working label Nov 5, 2024
@zanieb zanieb merged commit 515993c into main Nov 5, 2024
63 checks passed
@zanieb zanieb deleted the zb/build-backend-package branch November 5, 2024 20:15
@j178
Copy link
Contributor

j178 commented Nov 6, 2024

Just curious, doesn't #8593 already address this? 🤔

@zanieb
Copy link
Member Author

zanieb commented Nov 6, 2024

That's a great question — maybe I managed to not be on the latest version? I thought I checked main though. Will double check.

@zanieb
Copy link
Member Author

zanieb commented Nov 6, 2024

I reverted this commit and it looks like it does work as intended. Not sure what happened locally. Thanks!

zanieb added a commit that referenced this pull request Nov 6, 2024
@zanieb
Revert "Using --build-backend in uv init implies --package (#8837…
7c61f96 
…)"

This reverts commit 515993c.
@zanieb zanieb added internal A refactor or improvement that is not user-facing and removed bug Something isn't working labels Nov 6, 2024
@zanieb zanieb mentioned this pull request Nov 6, 2024
Merged
zanieb added a commit that referenced this pull request Nov 6, 2024
@zanieb
Revert "Using --build-backend in uv init implies --package (#8837…
129c6f6 
…)" (#8850)

This reverts commit 515993c from
#8837 as it was already implemented
differently in #8593 and I missed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @j178