Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APE6 example for round-tripping #49

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Fix APE6 example for round-tripping #49

merged 3 commits into from
Mar 8, 2019

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 12, 2018

Fix APE6 example for round-tripping, as suggested by @taldcroft (thanks!)

Fix #48

@taldcroft
Copy link
Member

The ECSV output needs to be updated to show float64:

# datatype:
# - {name: a, unit: m / s, datatype: int64, format: '%5.2f', description: Column A}
# - name: b
#   datatype: int64
#   meta:
#     column_meta: {a: 1, b: 2}

@pllim
Copy link
Member Author

pllim commented Dec 13, 2018

I updated the output by copying and pasting from my terminal. Good catch, @taldcroft !

Copy link
Member

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from needing to update the "last revised" date. But I did that myself here so, all good!

@eteq eteq merged commit 3787100 into astropy:master Mar 8, 2019
@pllim pllim deleted the patch-1 branch March 8, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants