Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npairs_per_object_3d has incorrect indexing #606

Closed
aphearin opened this issue Jul 22, 2016 · 0 comments
Closed

npairs_per_object_3d has incorrect indexing #606

aphearin opened this issue Jul 22, 2016 · 0 comments
Assignees
@aphearin
Labels
bug mock-observables
Milestone
v0.4

Comments

@aphearin
Copy link
Contributor

Total counts are correct, but the returned array needs to be "unsorted" in the same fashion as is currently done for the isolation functions.

CC @duncandc - I'll fix this, just fyi since you use this function. I'll tag this Issue in a commit I'm of a branch I'm about to push to my fork, where the commit provides the unit-test revealing the bug.
@aphearin aphearin added this to the v0.4 milestone Jul 22, 2016
@aphearin aphearin self-assigned this Jul 22, 2016
aphearin pushed a commit to aphearin/halotools that referenced this issue Jul 22, 2016
Discovered bug in npairs_per_object_3d.
234c296 
@duncandc - This is the unit-test that reveals bug in Issue astropy#606.
@aphearin aphearin mentioned this issue Jul 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aphearin aphearin

Labels
bug mock-observables
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@aphearin