-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cython extensions are compiled to c++ source code. #828
Comments
I'd love to get rid of the c++ compilation @rainwoodman - The only place where any cpp-specific feature is used is in the pairwise distance engines: |
I agree that it would be ideal to get rid of the C++ dependency. Let me take a look at those functions to see if we can get around using the |
Sorry I didn't realize it is using libcpp.vector.
…On Tue, Nov 14, 2017 at 9:18 AM, Duncan Campbell ***@***.***> wrote:
I agree that it would be ideal to get rid of the C++ dependency. Let me
take a look at those functions to see if we can get around using the
libcpp.vector library without any significant penalty.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#828 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIbTFllVINt_2uFwX-PFRnT9uz5wMemks5s2ct6gaJpZM4Qczog>
.
|
Those three functions are the only ones using libcpp.vector in the entire repo @rainwoodman - if you know of common workarounds for this, I would happily use those instead. These three functions do not need to be ultra-high performance. |
If there is a reasonably sized upper bound, can you simply allocate according to the bound and update a incremental growth of around 1.5x with |
It appears that halotools doesn't really need c++. If that's the case, using C makes life of downstream packaging a lot easier.
The text was updated successfully, but these errors were encountered: