-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving npairs(s, mu) performance and testing. #768
Conversation
…on which is used by the engine.
Performance is about 10x's worse for me when applying this code. Are there some compiling flags that we need implement? |
Cython's automated compiler flags are sufficiently good that a 10x improvement never occurs by simply adding flags. If you just run |
Excellent. That did the trick. It looks to be of order 50% performance increase over the code in the repo right now. Im going to push my modifications to the pair counters and tests to this PR. |
Okay, I plan on merging this with master after it passes the travis build. I think the brute force pairs.s_mu_npairs comparison test should alleviate any concern that may have been lingering about the reliability of the optimized npairs_s_mu() function. I have also edited the doc strings of the s_mu pair counters. |
@aphearin do you expect some travis builds to fail currently? |
okay, note that doc strings with math need to be preceded by an 'r' in order to pass python 3 builds. |
Completely un-tested, un-benchmarked. I am assuming there are existing tests for the npairs(s, mu) pair counters.
Related to #763