adding w_p jackknife mock observable #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following files have been modified relative to master: halotools/mock_observables/pair_counters/__init__.py halotools/mock_observables/pair_counters/cpairs/__init__.py halotools/mock_observables/pair_counters/cpairs/npairs_jackknife_rp_pi_engine.pyx halotools/mock_observables/pair_counters/cpairs/setup_package.py halotools/mock_observables/pair_counters/npairs_jackknife_rp_pi.py halotools/mock_observables/two_point_clustering/__init__.py halotools/mock_observables/two_point_clustering/wp_jackknife.py In particular, the user-facing function wp_jackknife has all the backend machinery in place so that the cython compiles and is appropriately linked, and all the relevant __init__ modules have the appropriate modifications. There are two failing doctests, one for wp_jackknife and another for npairs_jackknife_rp_pi. The failures are due to a NotImplementedError placed at the point where I left off. Running the test suite for either module will give an error message explaining that the primary remaining task is writing the npairs_jackknife_rp_pi_engine kernel to do 2+1 counting. Once that is implemented, the function *should* be correct, and the only remaining tasks are double-checking the docstrings of wp_jackknife and npairs_jackknife_rp_pi, writing a unit-test or two, and updating the changelog. @duncandc - I hoped this would help alleviate some of the infrastructure burden, but let me know if you have any questions about finishing up.
…tent with previous code names
…by a factor of 10
|
@duncandc - is this ready to merge as is? Or were you postponing until you can figure out a good unit-test? |
|
I think this can merge. I was postponing until we could figure out the jackknife weighting scheme, but let's leave that to a dedicated pull request for both wp and xi if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a projected two-point correlation function that calculates jackknife covariance matrices to the mock_observables.two_point_clustering package to address the long-standing issue #234.
Adding this function required coding up a redshift space jackknife pair counter and the associated Cython engine.