Remove reference cycles between MockFactory and ModelFactory. #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption is that mock is always a member of model anyways, so if a mock is alive, then the model is too. This breaks a cyclic reference.
The assumption here is self.param_dict is never replaced during the life cycle of the decorated function. It may be a good idea to enforce that by replacing param_dict with a read-only property.
aphearin
reviewed
Jul 3, 2018
| @@ -276,12 +276,12 @@ def update_param_dict_decorator(self, component_model, func_name): | |||
| :ref:`param_dict_mechanism` | |||
| """ | |||
|
|
|||
| def decorated_func(*args, **kwargs): | |||
| def decorated_func(*args, __param_dict__=self.param_dict, **kwargs): | |||
There was a problem hiding this comment.
@rainwoodman - this line seems to be causing problems for a few builds. Any idea why? See https://travis-ci.org/astropy/halotools/jobs/399786150.
There was a problem hiding this comment.
It's incompatible with Python 2.7. I pushed a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reference cyels between MockFactory and ModelFactory.
I used objgraph to dump the back references in
halotools/empirical_models/composite_models/tests/test_preloaded_models.py::test_hearin15Before the PR:
After the PR:
Unfortunately this does not cure #917. Memory usage still increase after these cycles are cured. There must be other cycles that I haven't found yet.