Mean delta sigma #955
Mean delta sigma #955
Conversation
… non-periodic boundary conditions
…ial unit-tests, but suspicious behavior on SV test. Need to implement Rhalo-based calculation in order to confirm whether there is a problem
…culation. Still needs SV testing
…e 1-2-halo decomposition of the lensing calculation. Everything checks out, so time to clean up and merge
|
This PR also introduces a 1-halo and 2-halo decomposition of the lensing signal, using the |
|
From what we've talked about, it sounds like there is no real downside to the change, just a slightly more accurate estimate? In that case I have no problem with it replacing the old function. I think there needs to be pretty strong justification to have duplicate functionality else it is confusing for users, and as far as I know there isn't that here. |
|
Hmm, I see your point. The current PR only raises a DeprecationWarning for the old delta_sigma, but maybe you’re right that it’s better for this function to be deleted entirely from the v0.7 release. |
Merging in the
mean_delta_sigmafunction written by @johannesulf.Currently keeping the name
mean_delta_sigma, although I think this function should outright replace the existingdelta_sigmafunction. The question is whether people who use Halotools for lensing calculations would be bothered, so soliciting input from @Christopher-Bradshaw, @dr-guangtou, @alexieleauthaud, and whoever else uses this function.