Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keyword argument supports user-defined halo boundary #995

Merged
merged 7 commits into from
Sep 18, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added new unit-test reproducing error reported by @jmsull and @rainwo…
  • Loading branch information
aphearin committed Sep 18, 2020

Verified

This commit was signed with the committer’s verified signature.
tfcollins Travis F. Collins
commit e851791b60de8528c880adee108202d70322ffae
Original file line number Diff line number Diff line change
@@ -104,3 +104,12 @@ def test_host_centric_distance():

msg = "host_centric_distance key was never mapped during mock population"
assert np.any(model.mock.galaxy_table["host_centric_distance"] > 0), msg


def test_mass_definition_flexibility():
""" Regression test for Issue #993.
"""
model = PrebuiltHodModelFactory("zheng07", mdef="200m")
halocat = FakeSim(seed=43)
halocat.halo_table["halo_m200m"] = np.copy(halocat.halo_table["halo_mvir"])
model.populate_mock(halocat, seed=43)