Skip to content

Commit

Permalink
HDDS-11562. Parameterize TestSCMNodeManager#testProcessLayoutVersion (a…
Browse files Browse the repository at this point in the history
  • Loading branch information
weimingdiit authored Oct 13, 2024
1 parent b51c4b3 commit 4c77f6b
Showing 1 changed file with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@

import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.EnumSource;
import org.junit.jupiter.params.provider.MethodSource;
import org.junit.jupiter.params.provider.ValueSource;
import org.mockito.ArgumentCaptor;
Expand Down Expand Up @@ -850,15 +851,12 @@ void testScmHandleJvmPause() throws Exception {
}
}

@Test
public void testProcessLayoutVersion() throws IOException {
// TODO: Refactor this class to use org.junit.jupiter so test
// parameterization can be used.
for (FinalizationCheckpoint checkpoint: FinalizationCheckpoint.values()) {
LOG.info("Testing with SCM finalization checkpoint {}", checkpoint);
testProcessLayoutVersionLowerMlv(checkpoint);
testProcessLayoutVersionReportHigherMlv(checkpoint);
}
@ParameterizedTest
@EnumSource(FinalizationCheckpoint.class)
public void testProcessLayoutVersion(FinalizationCheckpoint checkpoint) throws IOException {
LOG.info("Testing with SCM finalization checkpoint {}", checkpoint);
testProcessLayoutVersionLowerMlv(checkpoint);
testProcessLayoutVersionReportHigherMlv(checkpoint);
}

// Currently invoked by testProcessLayoutVersion.
Expand Down

0 comments on commit 4c77f6b

Please sign in to comment.